Fix missing field partitioned_by_file_group in serialization#22365
Merged
Conversation
adriangb
force-pushed
the
marc/fix-missing-field-pbf-group
branch
from
8b89211 to
6dec7ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not super versed in the serialization machinery involved here, please review carefully.
Which issue does this PR close?
partitioned_by_file_groupnot serialized inFileScanExecConfprotobuf breaks datafusion-distributed #22363.Rationale for this change
The partitioned_by_file_group field was introduced in #21351 and #21342 but not added to the protobuf schema, breaking
datafusion-distributed.What changes are included in this PR?
bool partitioned_by_file_group = 14toFileScanExecConfindatafusion.prototo_proto.rsfrom_proto.rsAre these changes tested?
Yes, added roundtrip_parquet_exec_partitioned_by_file_group test.
Are there any user-facing changes?
No