fix: error on negative ln inputs#22410
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
Contributor
|
There's already a pr for this issue #22276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ln(-1.0::float8)should error, not return NaN #22271.Rationale for this change
lncurrently delegates directly to Rust floating-pointln, so negative inputs produceNaN. PostgreSQL-style semantics for this case should return a domain error instead.What changes are included in this PR?
lnfrom the shared unary math macro to a focused implementation.Float32/Float64inputs while preserving the existingln(0) -> -Infinitybehavior.Are these changes tested?
Yes:
cargo test --profile=ci --test sqllogictests -- scalar.sltcargo test --profile=ci -p datafusion-functions math::lncargo fmt --allgit diff --checkcargo clippy --profile=ci --all-targets --all-features -- -D warningsAre there any user-facing changes?
Yes.
lnnow returns an error for negative floating-point inputs instead ofNaN.AI assistance: Used OpenAI GPT-5 to help draft and check this focused change; I reviewed the code and tests.