feat: benchmark_runner - added --list, optional DATA_DIR #23354
Open
Omega359 wants to merge 2 commits into
Open
feat: benchmark_runner - added --list, optional DATA_DIR #23354Omega359 wants to merge 2 commits into
Omega359 wants to merge 2 commits into
Conversation
…ferred if it's not provided, and moved some code back into benchmark_runner that is cli only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Code cleanup, usability improvements. Added
--listargument, DATA_DIR should now be properly inferred to the expected default if it's not provided.What changes are included in this PR?
benchmark tool update only.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.