Skip to content

Fix memory size accounting for grouped median and avg #23357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyne7-sc wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

Fix memory size accounting for grouped median and avg #23357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion datafusion/functions-aggregate/src/average.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,7 @@ where
}

fn size(&self) -> usize {
self.counts.capacity() * size_of::<u64>() + self.sums.capacity() * size_of::<T>()
self.counts.capacity() * size_of::<u64>()
+ self.sums.capacity() * size_of::<T::Native>()
Comment on lines +973 to +974

@comphead comphead Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.counts.capacity() * size_of::<u64>()
+ self.sums.capacity() * size_of::<T::Native>()
// Heap buffers
self.counts.capacity() * size_of::<u64>()
+ self.sums.capacity() * size_of::<T::Native>()
// Vec struct overhead (ptr, len, cap) for each field
+ size_of::<Vec<u64>>()
+ size_of::<Vec<T::Native>>()

Adding small overhead to maintain Vec

}
}
6 changes: 3 additions & 3 deletions datafusion/functions-aggregate/src/median.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,10 +543,10 @@ impl<T: ArrowNumericType + Send> GroupsAccumulator for MedianGroupsAccumulator<T
fn size(&self) -> usize {
self.group_values
.iter()
.map(|values| values.capacity() * size_of::<T>())
.map(|values| values.capacity() * size_of::<T::Native>())
.sum::<usize>()
// account for size of self.grou_values too
+ self.group_values.capacity() * size_of::<Vec<T>>()
// account for size of self.group_values too
+ self.group_values.capacity() * size_of::<Vec<T::Native>>()
}
}

Expand Down
Loading