Move main_inner into datafusion-cli lib for subsequent PR#23465
Open
ratmice wants to merge 1 commit into
Open
Conversation
Author
|
Second PR is up at #23466 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This patch lays the groundwork moves code from the datafusion_cli binary to the library, for a subsequent
PR which will refactor the moved code into the API.
Moving this code in a separate PR, the hope is that it will make the other PR more easily reviewable.
Rationale for this change
See the PR, and the subsequent PR.
What changes are included in this PR?
This PR purely moves code, and does the minimal changes to get it compiling in the library.
Are these changes tested?
Are there any user-facing changes?