Skip to content

test: add advanced dictionary test #23483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rich-T-kid wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −1
Open

test: add advanced dictionary test #23483

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60f98cb
add advanced dictionary test
Rich-T-kid Jul 11, 2026
fb5f276
PR revisions
Rich-T-kid Jul 14, 2026
4ca86a1
more obvious test
Rich-T-kid Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion datafusion/sqllogictest/test_files/dictionary.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,4 +632,22 @@ south 2
statement ok
DROP TABLE dict_count_distinct;


# same dictionary type but value order differs across batches so key ids refer to different strings;
# grouping must use the logical value, not the raw key id
query TI rowsort
WITH
first_batch AS (
SELECT arrow_cast(column1, 'Dictionary(Int32, Utf8)') AS region
FROM (VALUES ('west'), ('west'), ('west'), ('east'), (NULL)) AS t(column1)
),
second_batch AS (
SELECT arrow_cast(column1, 'Dictionary(Int32, Utf8)') AS region
FROM (VALUES ('east'), ('east'), ('east'), ('west'), (NULL)) AS t(column1)
)
SELECT region, count(*)
FROM (SELECT region FROM first_batch UNION ALL SELECT region FROM second_batch)
GROUP BY region;
----
NULL 2
east 4
west 4
Loading