feat: add metrics tracking for file sinks and update orchestration fo…#23490
Open
CadyLinn wants to merge 1 commit into
Open
feat: add metrics tracking for file sinks and update orchestration fo…#23490CadyLinn wants to merge 1 commit into
CadyLinn wants to merge 1 commit into
Conversation
…r metrics integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
CSV and JSON sinks do not currently expose write metrics through
DataSinkExec, while the Parquet sink exposesrows_written,bytes_written, andelapsed_compute.This change provides consistent metrics for CSV and JSON sinks and centralizes the common file sink metrics wiring to reduce duplication across file formats.
What changes are included in this PR?
FileSinkMetricsimplementation forrows_written,bytes_written, andelapsed_compute.spawn_writer_tasks_and_joinAPI and add an opt-in metrics variant.EXPLAIN ANALYZE COPYwith CSV and JSON output.Are these changes tested?
Yes. The affected datasource unit tests and the
copy.sltSQL logic test pass.cargo test -p datafusion-datasource \ -p datafusion-datasource-csv \ -p datafusion-datasource-json \ -p datafusion-datasource-parquet --libcargo test -p datafusion-sqllogictest \ --test sqllogictests -- copy.slt --completeThe affected crates also pass targeted Clippy checks with warnings denied.
Are there any user-facing changes?
Yes.
EXPLAIN ANALYZE COPYnow reportsrows_written,bytes_written, andelapsed_computefor CSV and JSON sinks, consistent with the existing Parquet sink metrics.There are no breaking public API changes.