Skip to content

perf: speedup date_part isodow by using DayOfWeekMonday1 #23491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theirix wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −10
Open

perf: speedup date_part isodow by using DayOfWeekMonday1 #23491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions datafusion/functions/src/datetime/date_part.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,16 +240,8 @@ impl ScalarUDFImpl for DatePartFunc {
"doy" => date_part(array.as_ref(), DatePart::DayOfYear)?,
"dow" => date_part(array.as_ref(), DatePart::DayOfWeekSunday0)?,
"isodow" => {
// Postgres `isodow` is 1..=7 with Mon=1. Arrow's
// `DayOfWeekMonday0` returns 0..=6 with Mon=0; shift by
// +1 to match Postgres. TODO: switch to a future
// `DatePart::DayOfWeekMonday1` upstream variant once it
// exists, so this kernel-then-add becomes a single call.
let zero_based =
date_part(array.as_ref(), DatePart::DayOfWeekMonday0)?;
let int_arr = as_int32_array(&zero_based)?;
let one_based: Int32Array = int_arr.unary(|v| v + 1);
Arc::new(one_based) as ArrayRef
// Postgres `isodow` is 1..=7 with Mon=1
date_part(array.as_ref(), DatePart::DayOfWeekMonday1)?
}
"epoch" => epoch(array.as_ref())?,
_ => return exec_err!("Date part '{part}' not supported"),
Expand Down
Loading