Merged
Conversation
Member
|
Can you confirm that this will still compile with C++ 11? |
leerho
approved these changes
Apr 13, 2026
Member
leerho
left a comment
leerho
left a comment
There was a problem hiding this comment.
This passes the CI checks, which are based on C++11, so this should be good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #499
I don't know exactly coverage what we covered. setting coverage is needed for ds-cpp project
Following the current CI machine(ubuntu 24.04), I tried to test all current supported gcc and new gcc 15.
And also we tried to cover from C++11, so add them too.