fix: make default query row limit configurable - #154
Merged
FreeOnePlus merged 1 commit intoJul 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_RESULT_ROWSas the per-query default forexec_queryMAX_RESULT_ROWSas the independent deployment ceilingRoot cause
MAX_RESULT_ROWSalready controlled the maximum allowed request, but both thetool schema and handler hardcoded an omitted
max_rowsargument to100.Increasing the deployment ceiling therefore did not change the default result
size.
User impact
Operators can now set, for example:
Clients that omit
exec_query.max_rowsreceive up to 1000 rows, while explicitrequests remain bounded by the 10000-row deployment ceiling.
Validation
uv run pytest -q: 1088 passed, 68 skipped; coverage 57.94%max_rowsusesDEFAULT_RESULT_ROWSuv run ruff check .uv run mypy doris_mcp_serveruv run bandit -r doris_mcp_server -c pyproject.tomluv builddocker compose config --quietFixes #66
Fixes #72