[improvement](compaction) split time series compaction score metric#63900
Draft
Yukang-Lian wants to merge 4 commits into
Draft
[improvement](compaction) split time series compaction score metric#63900Yukang-Lian wants to merge 4 commits into
Yukang-Lian wants to merge 4 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Add regression coverage for time-series compaction score zeroing, skipped policy score updates, empty scan behavior, and full local disk handling. Also avoid lowering cumulative policy score metrics when a capacity-limited disk is skipped and remove obsolete fallback metric update branches.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- ./run-be-ut.sh --run --filter=DorisMetricsTest.Normal:TabletMgrTest.FindTabletWithCompact:TabletMgrTest.FindBestTabletsIgnoresUnsuitablePolicyScore:TabletMgrTest.GenerateCompactionTasksClearsMissingPolicyScoreOnCheck:TabletMgrTest.GenerateCompactionTasksKeepsMissingPolicyScoreWithoutCheck:TabletMgrTest.GenerateCompactionTasksDoesNotUpdateMetricWhenNoDirScanned:TabletMgrTest.GenerateCompactionTasksAggregatesScoreWhenNoSlot:TabletMgrTest.GenerateCompactionTasksDoesNotLowerPolicyScoreWhenDirFull:CloudCompactionTest.failure_base_compaction_tablet_sleep_test:CloudCompactionTest.failure_cumu_compaction_tablet_sleep_test:CloudCompactionTest.split_cumu_compaction_score_stats_before_filter:CloudCompactionTest.generate_cloud_compaction_tasks_updates_policy_metrics:CloudCompactionTest.generate_cloud_compaction_tasks_clears_metrics_without_tablets -j 16
- Behavior changed: No
- Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Time series cumulative compaction and size-based cumulative compaction shared the same max compaction score metric.
This PR:
tablet_time_series_max_compaction_scoretablet_cumulative_max_compaction_scorefor size-based cumulative compactionRelease note
None