[fix](sort) keep heap TopN pruning for expression order keys#63902
Draft
Mryange wants to merge 1 commit into
Draft
[fix](sort) keep heap TopN pruning for expression order keys#63902Mryange wants to merge 1 commit into
Mryange wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31470 ms |
Contributor
TPC-DS: Total hot run time: 172273 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
For TopN queries with computed order keys, such as
SELECT MURMUR_HASH3_32(number) AS n FROM numbers_20m ORDER BY n LIMIT 65535, Doris created a TopN runtime predicate but could not push it down to storage because the target was an expression instead of a slot/key column. However, heap sort treated the existence of any runtime predicate as a reason to disable its local TopN pruning, so this path lost local pruning without gaining effective scan-side pruning.This PR narrows that condition. Heap sort now disables local TopN pruning only when the runtime predicate targets are all slots. Expression order keys keep the local heap filter, which restores early row pruning in the sorter.
In local reproduction of
function_order_by_number_limit_big, Doris improved from about 2.3s to 2.8s down to about 0.53s to 0.69s, and the new profile showsTopNFilterRows: 19.555616Minstead of0.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)