fix(common): omit trailing ? in URL.String() without query params#3328
Open
leno23 wants to merge 1 commit into
Open
fix(common): omit trailing ? in URL.String() without query params#3328leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Contributor
|
pls provide the demonstration before and after edit |
Closes apache#3327. Only append a query string when URL parameters exist.
leno23
force-pushed
the
fix/url-string-no-trailing-query-3327
branch
from
be514dc to
5ffbee8
Compare
|
Contributor
|
pls fix ci fail |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes URL.String() to omit the trailing ? when there are no query parameters, addressing issue #3327.
Changes:
- Removed the unconditional
?suffix in the URL prefix and only append?when encoded params are non-empty. - Added
TestURLStringWithoutQueryregression test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/url.go | Conditionally append ? and params only when params are non-empty. |
| common/url_test.go | New regression test verifying no trailing ? when there are no query parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
any progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL.String()no longer appends a bare?when the URL has no parameters.TestURLStringWithoutQueryregression test.Fixes #3327.
Test plan
go test ./common/... -run TestURLString