fix(marker): skip invalid markLine data items instead of crashing the…#21696
Open
aloktomarr wants to merge 1 commit into
Open
fix(marker): skip invalid markLine data items instead of crashing the…#21696aloktomarr wants to merge 1 commit into
aloktomarr wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Prevents a single empty/invalid
markLine.dataentry (e.g.{}) from throwing and wiping out all markLines in the series.Fixed issues
Details
Before: What was the problem?
An empty object
{}inmarkLine.datais normalized to[undefined, undefined, {...}].markLineFilterthen readitem[0].coord/item[1].coordon theundefinedendpoints, throwingTypeError: Cannot read properties of undefined (reading 'coord'). This aborted rendering of every markLine in the series, so no markLine was drawn at all.After: How does it behave after the fixing?
markLineFilternow treats an item with a missing endpoint as invalid and filters it out. The empty entry is skipped and the remaining valid markLines render normally. A regression unit test was added (test/ut/spec/component/marker/MarkLine.test.ts) that assertssetOptiondoes not throw and the valid markLines are still rendered.Document Info
Misc
Security Checking
ZRender Changes
Merging options