Skip to content

FINERACT-2695: enable dismiss stale reviews for PRs#6155

Open
meonkeys wants to merge 1 commit into
apache:developfrom
meonkeys:FINERACT-2695-dismiss-stale-reviews
Open

FINERACT-2695: enable dismiss stale reviews for PRs#6155
meonkeys wants to merge 1 commit into
apache:developfrom
meonkeys:FINERACT-2695-dismiss-stale-reviews

Conversation

@meonkeys

Copy link
Copy Markdown
Contributor

Description

This ensures new commits pushed to a PR are reviewed & approved.

FINERACT-2695

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

This ensures new commits pushed to a PR are reviewed & approved.

@Aman-Mittal Aman-Mittal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. But need to hear other's opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants