[FLINK-39118][docs] Add documentation for Native s3 FileSystem#27841
[FLINK-39118][docs] Add documentation for Native s3 FileSystem#27841RocMarshal merged 2 commits intoapache:masterfrom
Conversation
alpinegizmo
left a comment
There was a problem hiding this comment.
This is in pretty good shape. Just a couple of points to address.
7b82717 to
7be000d
Compare
alpinegizmo
left a comment
There was a problem hiding this comment.
One more suggestion, and a question.
Izeren
left a comment
There was a problem hiding this comment.
Thank you for the PR @Samrat002, I have left a few comments, PTAL.
My general request for changes is to replicate this for Chinese docs (usually we update both): https://github.com/apache/flink/blob/master/docs/content.zh/docs/deployment/filesystems/s3.md
It can be done in English for further translation.
a1af097 to
a0429ed
Compare
I have added a note in the PR description earlier. Once the English version content is good. I will add changes for chinese doc in this pr itself as a new commit. |
Izeren
left a comment
There was a problem hiding this comment.
LGTM, thank you for addressing feedback, @Samrat002
alpinegizmo
left a comment
There was a problem hiding this comment.
Thanks for the improvements!
21c9344 to
4265f70
Compare
gaborgsomogyi
left a comment
There was a problem hiding this comment.
Basically looks good, some minor tweaks and good to go
4265f70 to
f309c80
Compare
|
@gaborgsomogyi PTAL at the updated changes |
21e7d4c to
ed83cc8
Compare
ed83cc8 to
fdd683e
Compare
|
Thanks @Samrat002 for the PR and @alpinegizmo @gaborgsomogyi @Izeren for the review. |
What is the purpose of the change
Add documentation for Native s3 FileSystem
Brief change log
Add documentation and show how to use new s3Filesystem.
Verifying this change
Build the docs in local using Hugo
Chinese Doc Render :
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) yes