Skip to content

[server] Preserve exception cause when rethrowing exceptions in RpcServiceBase #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XuQianJin-Stars wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

[server] Preserve exception cause when rethrowing exceptions in RpcServiceBase #3329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fluss-common/src/main/java/org/apache/fluss/exception/KvSnapshotNotExistException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,8 @@ public class KvSnapshotNotExistException extends ApiException {
public KvSnapshotNotExistException(String message) {
super(message);
}

public KvSnapshotNotExistException(String message, Throwable cause) {
super(message, cause);
}
}
5 changes: 3 additions & 2 deletions fluss-server/src/main/java/org/apache/fluss/server/RpcServiceBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,8 @@ public CompletableFuture<GetKvSnapshotMetadataResponse> getKvSnapshotMetadata(
throw new KvSnapshotNotExistException(
String.format(
"Failed to get kv snapshot metadata for table bucket %s and snapshot id %s. Error: %s",
tableBucket, snapshotId, e.getMessage()));
tableBucket, snapshotId, e.getMessage()),
e);
}
}

Expand All @@ -456,7 +457,7 @@ public CompletableFuture<GetFileSystemSecurityTokenResponse> getFileSystemSecuri
remoteFileSystem.getUri().getScheme(), securityToken));
} catch (Exception e) {
throw new SecurityTokenException(
"Failed to get file access security token: " + e.getMessage());
"Failed to get file access security token: " + e.getMessage(), e);
}
}

Expand Down
Loading