[GOBBLIN-ICEBERG] Restore backward compat: CURRENT_DATE produces -00 …#4185
Merged
Blazer-007 merged 3 commits intoapache:masterfrom Apr 9, 2026
Merged
[GOBBLIN-ICEBERG] Restore backward compat: CURRENT_DATE produces -00 …#4185Blazer-007 merged 3 commits intoapache:masterfrom
Blazer-007 merged 3 commits intoapache:masterfrom
Conversation
…in legacy hourly mode
Blazer-007
requested changes
Apr 9, 2026
...-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java
Outdated
Show resolved
Hide resolved
...-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java
Outdated
Show resolved
Hide resolved
...-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java
Outdated
Show resolved
Hide resolved
...-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java
Outdated
Show resolved
Hide resolved
Blazer-007
reviewed
Apr 9, 2026
...-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java
Outdated
Show resolved
Hide resolved
… iceberg.partition.value.datetime.format
Blazer-007
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before this fix,
CURRENT_DATEin the legacy path (noiceberg.partition.value.datetime.formatset)resolved to
LocalDateTime.now(), causing the defaultyyyy-MM-dd-HHformatter to embed the liveclock-hour (e.g.
2026-04-06-20) instead of the expected-00suffix. This silently broke scheduledflows whose tables store daily data in
yyyy-MM-dd-00partitions — resulting in 0 files discoveredat any hour other than midnight.
Fix: split
CURRENT_DATEresolution by path:iceberg.partition.value.datetime.formatabsent) →LocalDate.now().atStartOfDay()— hour is always00, preserving pre-PR behavioriceberg.partition.value.datetime.formatset) →LocalDateTime.now()— live clock-hour is embedded for truly hourly-partitioned tablesTesting
testCurrentDatePlaceholderto asserttoday + "-00"(strict backward compat, deterministic)testCurrentDatePlaceholderWithCustomFormatfor the live-hour path (regex-based to avoid clock flakiness)Migration Guide
yyyy-MM-dd-00): no change needed — legacy default is preservediceberg.partition.value.datetime.format=yyyy-MM-dd-HH