Remove JApplet check from SwingBuilder factory registration#2449
Closed
jochenberger wants to merge 1 commit intoapache:masterfrom
Closed
Remove JApplet check from SwingBuilder factory registration#2449jochenberger wants to merge 1 commit intoapache:masterfrom
jochenberger wants to merge 1 commit intoapache:masterfrom
Conversation
`JApplet` has been deprecated for quite some time now (since Java 9) and was finally removed in Java 26. That means that SwingBuilder will stop working in Java 26: ``` Exception in thread "main" java.lang.RuntimeException: Could not init groovy.swing.SwingBuilder because of an exception in groovy.swing.SwingBuilder.registerBasicLayouts at groovy.util.FactoryBuilderSupport.callAutoRegisterMethods(FactoryBuilderSupport.java:211) at groovy.util.FactoryBuilderSupport.autoRegisterNodes(FactoryBuilderSupport.java:185) at groovy.util.FactoryBuilderSupport.<init>(FactoryBuilderSupport.java:163) at groovy.swing.SwingBuilder.<init>(SwingBuilder.groovy:101) at groovy.swing.SwingBuilder.<init>(SwingBuilder.groovy) ... Caused by: java.lang.reflect.InvocationTargetException at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:119) at java.base/java.lang.reflect.Method.invoke(Method.java:565) at groovy.util.FactoryBuilderSupport.callAutoRegisterMethods(FactoryBuilderSupport.java:206) ... 6 more Caused by: java.lang.NoClassDefFoundError: javax/swing/JApplet at groovy.swing.SwingBuilder.registerBeanFactory(SwingBuilder.groovy:303) at groovy.util.FactoryBuilderSupport.registerBeanFactory(FactoryBuilderSupport.java:644) at groovy.swing.SwingBuilder.registerBasicLayouts(SwingBuilder.groovy:229) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ... 8 more Caused by: java.lang.ClassNotFoundException: javax.swing.JApplet at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:580) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:502) ... 12 more ```
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JApplethas been deprecated for quite some time now (since Java 9) and was finally removed in Java 26. That means that SwingBuilder will stop working in Java 26: