GUACAMOLE-2276: Add and update Czech localization entries - #1213
Conversation
necouchman
left a comment
There was a problem hiding this comment.
Looks much better - just a couple of minor things.
|
anything else wrong? |
I left a couple of comments above that I do not see having been addressed or commented on? |
|
I tried to answer everything right away. Did I miss something? |
necouchman
left a comment
There was a problem hiding this comment.
Overall looks good, but the two lines that I had previously called out, I'm not sure why they're being modified at all? The lines were spaced such that they lined up with surrounding lines, which is consistent with the style in the translation files. As far as I can tell, there's no reason at all to modify those lines?
Sorry, it probably seems like I'm being pedantic or nit-picky, but we do have established style guidelines for reasons, and it'd be great if those two lines could just be restored to how they were before, as they're not really changing.
|
Hello Nick, is it ok now? :-) |
mike-jumper
left a comment
There was a problem hiding this comment.
The FIELD_HEADER_RECORDING_INCLUDE_CLIPBOARD strings were introduced as part of GUACAMOLE-1969, which is part of 1.7.0 (main). To include this in a patch release or within the upcoming 1.6.1, the changes that define that string will need to be moved to a different PR specific to 1.7.0.
Otherwise, LGTM, and should be good to base off staging/1.6.1.
Co-authored-by: Cursor <cursoragent@cursor.com>
Update
cs.jsonfor the 1.6.1 release line.Added translations
CLIENT.ERROR_CLIENT_205- connection resource sharing errorPLAYER.ACTION_CLOSE- recording player close actionUpdated translations
CLIENT.HELP_MOUSE_MODE_ABSOLUTE- remove mixed English wordingPLAYER.INFO_NUMBER_OF_RESULTS- Czech plural forms (shoda/shody/shod)FIELD_HEADER_FONT_NAME/FIELD_HEADER_FONT_SIZE- standardized to "Název písma" / "Velikost písma" (Kubernetes, SSH, Telnet)