Skip to content

GUACAMOLE-2276: Add and update Czech localization entries - #1213

Merged
necouchman merged 1 commit into
apache:staging/1.6.1from
Vict0rC:patch
Jul 15, 2026
Merged

GUACAMOLE-2276: Add and update Czech localization entries#1213
necouchman merged 1 commit into
apache:staging/1.6.1from
Vict0rC:patch

Conversation

@Vict0rC

@Vict0rC Vict0rC commented May 21, 2026

Copy link
Copy Markdown
Contributor

Update cs.json for the 1.6.1 release line.

Added translations

  • CLIENT.ERROR_CLIENT_205 - connection resource sharing error
  • PLAYER.ACTION_CLOSE - recording player close action

Updated translations

  • CLIENT.HELP_MOUSE_MODE_ABSOLUTE - remove mixed English wording
  • PLAYER.INFO_NUMBER_OF_RESULTS - Czech plural forms (shoda / shody / shod)
  • FIELD_HEADER_FONT_NAME / FIELD_HEADER_FONT_SIZE - standardized to "Název písma" / "Velikost písma" (Kubernetes, SSH, Telnet)

@necouchman necouchman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better - just a couple of minor things.

Comment thread guacamole/src/main/frontend/src/translations/cs.json
Comment thread guacamole/src/main/frontend/src/translations/cs.json
@Vict0rC

Vict0rC commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

anything else wrong?

@necouchman

Copy link
Copy Markdown
Contributor

anything else wrong?

I left a couple of comments above that I do not see having been addressed or commented on?

@Vict0rC

Vict0rC commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

I tried to answer everything right away. Did I miss something?

@Vict0rC
Vict0rC requested a review from necouchman June 18, 2026 07:28

@necouchman necouchman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but the two lines that I had previously called out, I'm not sure why they're being modified at all? The lines were spaced such that they lined up with surrounding lines, which is consistent with the style in the translation files. As far as I can tell, there's no reason at all to modify those lines?

Sorry, it probably seems like I'm being pedantic or nit-picky, but we do have established style guidelines for reasons, and it'd be great if those two lines could just be restored to how they were before, as they're not really changing.

Comment thread guacamole/src/main/frontend/src/translations/cs.json
Comment thread guacamole/src/main/frontend/src/translations/cs.json
@Vict0rC

Vict0rC commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Hello Nick, is it ok now? :-)

@Vict0rC Vict0rC changed the title GUACAMOLE-2276: Update Czech translations: add options & fixes GUACAMOLE-2276: Add and update Czech localization entries Jun 30, 2026

@mike-jumper mike-jumper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FIELD_HEADER_RECORDING_INCLUDE_CLIPBOARD strings were introduced as part of GUACAMOLE-1969, which is part of 1.7.0 (main). To include this in a patch release or within the upcoming 1.6.1, the changes that define that string will need to be moved to a different PR specific to 1.7.0.

Otherwise, LGTM, and should be good to base off staging/1.6.1.

@Vict0rC
Vict0rC requested a review from mike-jumper July 14, 2026 19:06
Co-authored-by: Cursor <cursoragent@cursor.com>
@necouchman
necouchman changed the base branch from patch to staging/1.6.1 July 15, 2026 00:23
@necouchman
necouchman merged commit 1549746 into apache:staging/1.6.1 Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants