[fix] persist custom monitor labels when writing to GreptimeDB#4151
Open
wilmerdooley wants to merge 1 commit into
Open
[fix] persist custom monitor labels when writing to GreptimeDB#4151wilmerdooley wants to merge 1 commit into
wilmerdooley wants to merge 1 commit into
Conversation
Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
GreptimeDbDataStorage.saveDatapreviously ignored the custom labels returned byMetricsData.getLabels()when building the GreptimeDBTable, so monitor labels were silently dropped on write. The fix mirrors howVictoriaMetricsDataStorageandDorisDataStoragepersist labels: each non-colliding custom label is added as aStringtag column on the table schema, and its value is appended to the row after the field columns. To preserve existing field column ordering, the row value array is sized as2 + fields.size() + labelKeys.size()and label values are written at index2 + fields.size() + i. Reserved keys that would collide with the built-ininstanceandtscolumns, or with an existing field name, are skipped. A regression test inGreptimeDbDataStorageTestcaptures the writtenTablewith anArgumentCaptorand asserts the custom label appears as aTAGcolumn and that its value is present in the row.Resolves #4124
Checklist
Add or update API