Skip to content

Generate metric scheduling intervals lazily - #4290

Merged
Duansg merged 3 commits into
apache:masterfrom
zqr10159:maintenance/metrics-interval-scheduling
Aug 3, 2026
Merged

Generate metric scheduling intervals lazily#4290
Duansg merged 3 commits into
apache:masterfrom
zqr10159:maintenance/metrics-interval-scheduling

Conversation

@zqr10159

Copy link
Copy Markdown
Member

Summary

  • generate exact metric refresh delays lazily instead of precomputing a full least-common-multiple cycle
  • preserve explicit one-time timer overrides and a positive fallback interval
  • make the standalone least-common-multiple helper fail fast on overflow

Validation

  • ./mvnw -pl hertzbeat-common-core -Dtest=JobTest test -DskipITs -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false
  • ./mvnw -pl hertzbeat-collector/hertzbeat-collector-common -am -Dtest=JobTest,TimerDispatcherTest test -DskipITs -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false
  • git diff --check

AI assistance: used for draft implementation and test iteration.
Human validation: focused common-core and timer-dispatcher tests passed (15 tests total), with Checkstyle and diff hygiene passing.
Risk notes: collector-local scheduling state is now generated on demand; serialized job fields and explicit timer overrides remain unchanged.

@zqr10159
zqr10159 marked this pull request as ready for review July 31, 2026 02:51
@Duansg
Duansg merged commit e03e0e0 into apache:master Aug 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants