Fix H2 stream timeout handling on inbound frames#657
Merged
arturobernalg merged 1 commit intoapache:masterfrom Mar 31, 2026
Merged
Fix H2 stream timeout handling on inbound frames#657arturobernalg merged 1 commit intoapache:masterfrom
arturobernalg merged 1 commit intoapache:masterfrom
Conversation
ok2c
reviewed
Mar 30, 2026
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
Show resolved
Hide resolved
ok2c
approved these changes
Mar 30, 2026
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg Please remove unnecessary code. Looks good otherwise.
| streams.resetIfExceedsMaxConcurrentLimit(stream, localConfig.getMaxConcurrentStreams()); | ||
| } | ||
| if (resetIfExpired(stream, nowNanos)) { | ||
| requestSessionOutput(); |
Member
There was a problem hiding this comment.
@arturobernalg This is unnecessary. Any outgoing frame automatically triggers output interest automatically.
arturobernalg
force-pushed
the
checkExpiry
branch
from
1507763 to
9f14f0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes H2 stream timeout handling for delayed inbound frames.
Expired streams are now reset before inbound DATA, HEADERS, CONTINUATION, or PUSH_PROMISE frames can refresh stream activity. Regression tests have been added for the affected code paths.