OpenAPI: Remove credentials from LoadViewResult#11433
Merged
RussellSpitzer merged 1 commit intoOct 30, 2024
Merged
Conversation
Member
|
@danielcweeks Please review ASAP for the 1.7.0 release. Like the other pr in core #11173 , this removes a detail in the spec that was added 2 weeks ago. We realize this may have been premature and want to remove it before adding it to the spec. |
RussellSpitzer
approved these changes
Oct 30, 2024
singhpk234
approved these changes
Oct 30, 2024
Member
|
Thanks @nastra , also @jbonofre and @singhpk234 for review |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original idea why credentials were added to
LoadViewResponsewas to pass back the credentials to the table that the view is referencing. However, we actually want to wait with this until we have the use case fully defined on how this will work and want to remove the functionality for now, as otherwise we'd have to maintain reading/writing credentials inLoadViewResponseforever.We'll we sharing a separate proposal on how to realize this shortly on the mailing list.