API: Fix null/Nan counts in evaluator test - #17419
Merged
amogh-jahagirdar merged 2 commits intoJul 30, 2026
Merged
Conversation
The single_value_nulls fixtures in testNotEqWithSingleValue and testNotInWithSingleValue reported 2 nulls for field 3, the "required" column. A required column cannot contain nulls, so no writer produces those metrics. Move both to the optional "some_empty" column, which keeps the case the tests cover: a file whose bounds hold a single value still has to be read when the column also contains nulls, because those nulls match != and NOT IN. The NOT IN fixture also reported a NaN count for a string column, which only float and double columns track.
The range_of_values and single_value fixtures reported a NaN count for field 3, a string column. Only float and double columns track NaN counts, which is why the single_value fixture in testNotEqWithSingleValue already passed null for them. Generated-by: Cursor
nastra
changed the title
nastra
commented
Jul 29, 2026
| ImmutableMap.of(3, 10L), | ||
| ImmutableMap.of(3, 0L), | ||
| ImmutableMap.of(3, 0L), | ||
| null, |
Contributor
Author
There was a problem hiding this comment.
this and the other places were reporting NaN counts for a string column
uros-b
approved these changes
Jul 29, 2026
pvary
approved these changes
Jul 30, 2026
amogh-jahagirdar
approved these changes
Jul 30, 2026
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
Contributor
There was a problem hiding this comment.
+1 to fixing these tests to represent realistic situations. Even though it's testing a different abstraction where it doesn't matter, it's best to have these cases be representative as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single_value_nulls fixtures in testNotEqWithSingleValue and testNotInWithSingleValue reported 2 nulls for field 3, the "required" column. A required column cannot contain nulls, so no writer produces those metrics. Move both to the optional "some_empty" column, which keeps the case the tests cover: a file whose bounds hold a single value still has to be read when the column also contains nulls, because those nulls match != and NOT IN.
The NOT IN fixture also reported a NaN count for a string column, which only float and double columns track.
metrics no writer can produce, and fix it on a separate branch off main.