Parquet: Guard ordered predicates on variant/nested types in metrics row group filter - #17431
Open
vishnuprakaz wants to merge 1 commit into
Open
Parquet: Guard ordered predicates on variant/nested types in metrics row group filter#17431vishnuprakaz wants to merge 1 commit into
vishnuprakaz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParquetMetricsRowGroupFilteralready skips variant and nested types ineq,in, andnotNull, leaving them to post-scan evaluation (#14081, #14279), since those columns have no primitive row-group stats keyed by field id. The ordered predicateslt,ltEq,gt, andgtEqwere missed: a variant/nested reference falls through tovalueCount == null, returnsROWS_CANNOT_MATCH, and the row group is skipped, dropping matching rows. This applies the same guard to the four ordered comparisons, following #14279.Tested by
testVariantFieldLt/LtEq/Gt/GtEq, which mirror the existing varianteq/intests and fail without the change.