Skip to content

feat(partitions): add consensus per partition and extra#3071

Open
numinnex wants to merge 11 commits intomasterfrom
store_consumer_offset
Open

feat(partitions): add consensus per partition and extra#3071
numinnex wants to merge 11 commits intomasterfrom
store_consumer_offset

Conversation

@numinnex
Copy link
Copy Markdown
Contributor

@numinnex numinnex commented Apr 2, 2026

Implement StoreConsumerOffset and DeleteConsumerOffset as replicated operations on partition. Additionally move partitions to an consensus per partition model, rather than relying on one instance of consensus for all of the partitions.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 43.55920% with 758 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.58%. Comparing base (f5350d9) to head (b769464).

Files with missing lines Patch % Lines
core/partitions/src/iggy_partition.rs 36.86% 550 Missing and 10 partials ⚠️
core/consensus/src/observability.rs 39.34% 74 Missing ⚠️
core/partitions/src/types.rs 0.00% 37 Missing ⚠️
core/partitions/src/offset_storage.rs 0.00% 33 Missing ⚠️
core/shard/src/lib.rs 85.12% 27 Missing and 2 partials ⚠️
core/partitions/src/iggy_partitions.rs 48.14% 14 Missing ⚠️
core/simulator/src/client.rs 0.00% 11 Missing ⚠️

❌ Your patch check has failed because the patch coverage (43.55%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3071      +/-   ##
============================================
- Coverage     72.76%   72.58%   -0.18%     
  Complexity      943      943              
============================================
  Files          1117     1117              
  Lines         96368    96380      +12     
  Branches      73544    73573      +29     
============================================
- Hits          70119    69958     -161     
- Misses        23702    23848     +146     
- Partials       2547     2574      +27     
Components Coverage Δ
Rust Core 73.30% <43.55%> (-0.20%) ⬇️
Java SDK 62.30% <ø> (ø)
C# SDK 69.10% <ø> (-0.33%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.40% <ø> (-0.13%) ⬇️
Go SDK 39.41% <ø> (ø)
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/operation.rs 94.36% <100.00%> (+0.16%) ⬆️
core/binary_protocol/src/dispatch.rs 90.99% <100.00%> (+0.08%) ⬆️
core/partitions/src/journal.rs 26.85% <100.00%> (+8.41%) ⬆️
core/partitions/src/lib.rs 0.00% <ø> (ø)
core/shard/src/router.rs 0.00% <ø> (ø)
core/simulator/src/lib.rs 84.43% <100.00%> (+0.56%) ⬆️
core/simulator/src/replica.rs 100.00% <100.00%> (ø)
core/simulator/src/client.rs 42.55% <0.00%> (-3.61%) ⬇️
core/partitions/src/iggy_partitions.rs 43.65% <48.14%> (+11.97%) ⬆️
core/shard/src/lib.rs 80.03% <85.12%> (-6.97%) ⬇️
... and 4 more

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread core/partitions/src/iggy_partitions.rs Outdated
Comment thread core/partitions/src/iggy_partition.rs Outdated
Comment thread core/partitions/src/offset_storage.rs
Comment thread core/partitions/src/iggy_partition.rs
Comment thread core/partitions/src/iggy_partition.rs
Comment thread core/partitions/src/iggy_partition.rs Outdated
Comment thread core/partitions/src/iggy_partition.rs Outdated
Comment thread core/partitions/src/iggy_partition.rs
@numinnex numinnex changed the title feat(partitions): implement StoreConsumerOffset and DeleteConsumerOffset feat(partitions): add consensus per partition and extra Apr 8, 2026
@numinnex numinnex requested a review from hubcio April 8, 2026 16:42
hubcio
hubcio previously approved these changes Apr 16, 2026
spetz
spetz previously approved these changes Apr 16, 2026
@numinnex numinnex dismissed stale reviews from spetz and hubcio via b769464 April 16, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants