fix(bench): anchor hero display to showcase pick, fix gitref links#3147
Merged
Conversation
mmodzelewski
approved these changes
Apr 21, 2026
numinnex
approved these changes
Apr 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3147 +/- ##
=============================================
- Coverage 73.25% 19.35% -53.91%
Complexity 943 943
=============================================
Files 1126 1124 -2
Lines 98435 87640 -10795
Branches 75609 64814 -10795
=============================================
- Hits 72108 16962 -55146
- Misses 23720 70286 +46566
+ Partials 2607 392 -2215
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hero headline read hardware from stale context and name from
the sweep's peak-throughput benchmark, so displayed fields
often didn't match the tail chart or "View details" target.
Route all hero headline fields through a single
showcase_displayhelper sourced from the same pick thatdrives the chart and detail link. Gitref URL now prefixes
server-only for parseable semver tags; raw commits linkunmodified (iggy releases tag as
server-X.Y.Z, commits donot).