fix(bench): fix mobile layout, compare URL, and shared branded loader#3148
Merged
Conversation
spetz
force-pushed
the
bench_loader_mobile
branch
from
e38dbb2 to
daa2a3d
Compare
mmodzelewski
approved these changes
Apr 21, 2026
numinnex
approved these changes
Apr 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3148 +/- ##
=============================================
- Coverage 73.26% 19.36% -53.90%
Complexity 943 943
=============================================
Files 1126 1124 -2
Lines 98435 87640 -10795
Branches 75610 64815 -10795
=============================================
- Hits 72118 16972 -55146
- Misses 23713 70277 +46564
+ Partials 2604 391 -2213
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile detail view went blank because a desktop
.sidebar-collapsedrule left the grid with two columns but onlyone area; Compare URL reverted to
/benchmarks/:uuidbecauseSingleChartforce-pushed history on prop change; loading stateswere inconsistent and the pre-WASM splash jumped when the app
mounted.
Mobile rules moved to end-of-file so they win the cascade, both
.detail-layoutand.sidebar-collapsedshare one mobile grid,and below 768px html/body/app-shell drop their 100vh locks so the
page scrolls naturally.
SingleChartno longer writes history. Ashared
IggyLoaderreplaces the legacy spinner, and the bootsplash is a position-fixed overlay centered the same way the hero
loading is. PNG logos (870 KB) swapped for SVG (21 KB). Row
select + compare are now sibling buttons, so clicking compare
never triggers the row's select handler.