feat(shard): add v2 consumer-offset commands with AckLevel#3151
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3151 +/- ##
============================================
- Coverage 74.46% 74.41% -0.05%
Complexity 943 943
============================================
Files 1183 1186 +3
Lines 105866 106343 +477
Branches 82899 83393 +494
============================================
+ Hits 78835 79138 +303
- Misses 24289 24433 +144
- Partials 2742 2772 +30
🚀 New features to boost your workflow:
|
numinnex
reviewed
Apr 22, 2026
Contributor
|
This command suppose to be implemented only in the components that are used by the cluster which is in development, not by our core server. |
bbb3eee to
a3b9e66
Compare
atharvalade
suggested changes
Apr 24, 2026
80165a5 to
7f2f668
Compare
numinnex
approved these changes
May 6, 2026
hubcio
approved these changes
May 6, 2026
spetz
approved these changes
May 6, 2026
Standing-Man
pushed a commit
to Standing-Man/iggy
that referenced
this pull request
May 6, 2026
- Introduce `AckLevel { NoAck, Quorum }` and v2 wire commands
`StoreConsumerOffset2` / `DeleteConsumerOffset2` that carry an explicit
ack byte; v1 commands and wire format are untouched.
- Unify the server's two offset-write paths so `PollMessages`
auto-commit and explicit stores share a single shard entry point, with
`AckLevel` selecting the policy.
Standing-Man
pushed a commit
to Standing-Man/iggy
that referenced
this pull request
May 6, 2026
- Introduce `AckLevel { NoAck, Quorum }` and v2 wire commands
`StoreConsumerOffset2` / `DeleteConsumerOffset2` that carry an explicit
ack byte; v1 commands and wire format are untouched.
- Unify the server's two offset-write paths so `PollMessages`
auto-commit and explicit stores share a single shard entry point, with
`AckLevel` selecting the policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AckLevel { NoAck, Quorum }and v2 wire commandsStoreConsumerOffset2/DeleteConsumerOffset2that carry an explicit ack byte; v1 commands and wire format are untouched.PollMessagesauto-commit and explicit stores share a single shard entry point, withAckLevelselecting the policy.