feat(configs): add address validation for QUIC/HTTP builders#3152
Conversation
QUIC/HTTP buildersQUIC/HTTP builders
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3152 +/- ##
============================================
- Coverage 73.79% 71.16% -2.63%
Complexity 943 943
============================================
Files 1190 1190
Lines 107692 102963 -4729
Branches 84709 79997 -4712
============================================
- Hits 79468 73277 -6191
- Misses 25467 26732 +1265
- Partials 2757 2954 +197
🚀 New features to boost your workflow:
|
|
looks good, but next time please comment under the issue before implementation and wait till we give a green light. |
b4efaa8 to
751b415
Compare
|
Hi @hubcio, @spetz, @numinnex and @mmodzelewski, just a gentle ping — this PR is ready on my side. Could you please take a look when convenient? |
|
@Standing-Man do you have plans to continue? this is good change, just needs a little bit more polishing |
@hubcio, I’ll continue polishing this PR — I’ve been a bit busy recently. |
b411449 to
46af920
Compare
|
Hi @hubcio, thank you very much for your detailed review. I’ve addressed the following issues in the latest commit:
|
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
46af920 to
1c2efbc
Compare
Which issue does this PR close?
Closes #3075.
Rationale
To align with the build methods in the
tcp/websocketbuilders, add validation forserver_addressandapi_urlinQuicClientConfigBuilder::build()andHttpClientConfigBuilder::build(), respectively.What changed?
In
QuicClientConfigBuilder::build(),server_addressis validated usingvalidate_server_address.In
HttpClientConfigBuilder::build(), validation is performed in three steps:api_urlcan be successfully parsed byUrlcratehttporhttpsapi_urlcontains only thehostandportcomponents in its URILocal Execution
Passed
Ran
AI Usage