feat(python): expose structured IggyError - #3696
Conversation
…, minor fixes, updated README
|
/ready |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3696 +/- ##
============================================
- Coverage 73.99% 73.99% -0.01%
Complexity 937 937
============================================
Files 1301 1302 +1
Lines 147393 147405 +12
Branches 122945 122945
============================================
+ Hits 109063 109070 +7
- Misses 34858 34863 +5
Partials 3472 3472
🚀 New features to boost your workflow:
|
|
@mmmmxa Will come back to this once all existing python sdk PRs are merged since they will require aligning the error types to the struct introduced here. |
|
/request-review @slbotbm |
|
@slbotbm Could you please let me know when it’s going to happen? Or let me know a way of finding out when should I merge the master and make same changes to the new code as well? |
|
sure, when the other prs are merged, i'll review yours and ping you |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either Thank you for your contribution! |
slbotbm
left a comment
There was a problem hiding this comment.
The docs for the methods are not updated. Please update them to include IggyError in them as well. If the methods are following the old way of documentation with 1-2 lines of docs, could you update them to follow the new way that aligns with normal python lib docs as well please?
Which issue does this PR address?
Closes #3618
Rationale
Introduce
IggyErrorclass in Python SDK to fully represent Iggy-specific errors from Rust. (See issue for more info)What changed?
Python was exposing Iggy failures as plain RuntimeError or ValueError with only a message, while no code and snake case error name was provided.
The changes introduce the
IggyErrorPython class that representIggyErrorin Rust 1 to 1. Thus, it has code, message and the snake case error name, which gives more transparency in debugging and more information for clean exception handling.Local Execution
AI Usage