-
Notifications
You must be signed in to change notification settings - Fork 367
perf(server-ng): reach single-node latency parity with legacy server #3746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hubcio
wants to merge
1
commit into
master
Choose a base branch
from
feat/server-ng-perf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
load_all()reads and materializes an entire.indexfile on the poll hot path with no boundcore/partitions/src/iggy_index_reader.rs:126Index density is one sparse entry per flush, governed by
messages_required_to_saveandsize_of_messages_required_to_save(core/server-ng/config.toml:515,520). At defaults a 1 GiB segment yields about 1024 entries, a 24 KiB read, and the "index files are tiny" comment holds. Setmessages_required_to_save = 1, which is what in-treerepair_config()uses, with 100-byte messages, and the same segment yields 7.25M entries: a single 174 MBread_exact_atissued from inside a poll, which compio will punt to io-wq. That is the exact stall this PR set out to remove, now reachable by supported config. There is no cap, no chunking, and no fallback.This also reintroduces up to 12 resident index caches per partition, which is the thing
core/partitions/src/iggy_partition.rs:2731-2736deliberately drops at rotation, with a comment naming retained hundreds of MB as the reason.Since
IggyIndexCacheis sorted and only ever binary-searched (core/partitions/src/iggy_index.rs:91,105), the bounded alternative is roughly 20 24-byteread_entry_atpreads above a byte budget; the reader already has that primitive at:67.