-
Notifications
You must be signed in to change notification settings - Fork 368
ci(rust): skip unnecessary setup steps #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Standing-Man
wants to merge
5
commits into
apache:master
Choose a base branch
from
Standing-Man:ci-opt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+383
−116
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8d59811
ci(rust): skip unnecessary setup steps
Standing-Man c89c343
ci(rust): reuse compiled tests across nextest partitions
Standing-Man f7553ba
fix(ci): address review comments
Standing-Man 3a09a49
fix(ci): address review comments again
Standing-Man 3d0f538
Merge branch 'master' into ci-opt
numinnex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: _test_rust | ||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| component: | ||
| type: string | ||
| required: true | ||
| description: "Rust component to test" | ||
| task: | ||
| type: string | ||
| required: true | ||
| description: "Rust task to run" | ||
| secrets: | ||
| CODECOV_TOKEN: | ||
| required: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| run: | ||
| if: inputs.task != 'test' | ||
| uses: ./.github/workflows/_test.yml | ||
| with: | ||
| component: ${{ inputs.component }} | ||
| task: ${{ inputs.task }} | ||
| secrets: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| build-rust-tests: | ||
| if: inputs.task == 'test' | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Build and archive Rust tests | ||
| uses: ./.github/actions/rust/pre-merge | ||
| with: | ||
| task: test-build | ||
| component: ${{ inputs.component }} | ||
|
|
||
| - name: Upload build coverage to Codecov | ||
| uses: codecov/codecov-action@v7.0.0 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: codecov.json | ||
| disable_search: true | ||
| flags: rust | ||
| fail_ci_if_error: false | ||
| verbose: true | ||
| override_pr: ${{ github.event.pull_request.number }} | ||
|
|
||
| - name: Upload build reports | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: rust-test-build-reports-${{ github.run_id }}-${{ github.run_attempt }} | ||
| path: | | ||
| target/llvm-cov/** | ||
| codecov.json | ||
| if-no-files-found: ignore | ||
| retention-days: 7 | ||
|
|
||
| run-rust-tests: | ||
| if: inputs.task == 'test' | ||
| needs: build-rust-tests | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| partition: [1, 2] | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Run Rust test partition | ||
| uses: ./.github/actions/rust/pre-merge | ||
| with: | ||
| task: test-run-${{ matrix.partition }} | ||
| component: ${{ inputs.component }} | ||
| test-partition-count: ${{ strategy.job-total }} | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v7.0.0 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: codecov.json | ||
| disable_search: true | ||
| flags: rust | ||
| fail_ci_if_error: false | ||
| verbose: true | ||
| override_pr: ${{ github.event.pull_request.number }} | ||
|
|
||
| - name: Upload reports | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: rust-test-${{ matrix.partition }}-reports-${{ github.run_id }}-${{ github.run_attempt }} | ||
| path: | | ||
| target/llvm-cov/** | ||
| codecov.json | ||
| if-no-files-found: ignore | ||
| retention-days: 7 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/bin/bash | ||
| #!/usr/bin/env bash | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unrelated to either commit in this PR, and incomplete - four other scripts under |
||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cuts the noise a lot but doesn't remove it. the previous run had 85
*-rust-testsrows, 82 of them skipped, across 41 callers. now that onlytest-rustreaches these jobs the SDK callers drop to zero, but each of the eleven non-testrust tasks still materialises a skippedbuild-rust-testsand a skippedrun-rust-tests, so about 22 skipped rows remain plus one for the skippedrunforward onrust/test.to get to zero the split has to move a level up - have
_detect.ymlemit thetesttask separately from the rest ofrust_matrix, then this workflow holds only the build and partition jobs and never needs therunforward at all. not required here, but that's the shape that actually makes the check list clean.