feat(server-ng): harden listener, auth, shutdown, and disk-poll paths - #3774
Open
numinnex wants to merge 3 commits into
Open
feat(server-ng): harden listener, auth, shutdown, and disk-poll paths#3774numinnex wants to merge 3 commits into
numinnex wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3774 +/- ##
=============================================
- Coverage 75.12% 61.15% -13.97%
Complexity 969 969
=============================================
Files 1307 1306 -1
Lines 152751 140486 -12265
Branches 128184 115991 -12193
=============================================
- Hits 114756 85920 -28836
- Misses 34465 50964 +16499
- Partials 3530 3602 +72
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silent failure modes become loud or typed: listeners no longer set
SO_REUSEPORT, so a stale process holding a port fails the bind instead
of splitting the accept queue (UDP/QUIC drops SO_REUSEADDR too, which
alone lets a second socket steal datagrams); a disk poll that cannot
resolve its partition dir mid-rotation now fails closed instead of
letting the journal-forward skip disk-resident offsets; rejected logins
get a typed Eviction frame with the real reason instead of an empty
reply; a wedged shard is abandoned at a configurable join deadline
instead of blocking process exit forever.
Cluster operability: a verify-only acceptance window for the retiring
PSK (cluster.auth.previous_shared_secret) makes key rotation a rolling
three-step instead of a coordinated restart, and replica TLS names are
keyed by replica id rather than roster position so sparse ids from
dynamic join cannot verify against another peer's name.
Also removes a stale rustdoc pointer to the already-landed resumable
TLS pump framing.