JCR-2768 Replace finalize in SessionImpl with Phantom references#17
Open
gruberroland-netcentric wants to merge 7389 commits intoapache:trunkfrom
Open
JCR-2768 Replace finalize in SessionImpl with Phantom references#17gruberroland-netcentric wants to merge 7389 commits intoapache:trunkfrom
gruberroland-netcentric wants to merge 7389 commits intoapache:trunkfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the finalize function in SessionImpl. The garbage collection runs much smoother now.
Tested with 20 threads that open 20000 sessions each and create 50 nodes. Images are from https://github.com/chewiebug/GCViewer.
Original code:
Patch:
