[LIVY-560] Added support for hostnames that resolve to an external address#145
Closed
smrtl wants to merge 1 commit into
Closed
[LIVY-560] Added support for hostnames that resolve to an external address#145smrtl wants to merge 1 commit into
smrtl wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
============================================
- Coverage 68.59% 68.54% -0.05%
Complexity 904 904
============================================
Files 100 100
Lines 5662 5666 +4
Branches 848 848
============================================
Hits 3884 3884
- Misses 1225 1230 +5
+ Partials 553 552 -1
Continue to review full report at Codecov.
|
Author
|
Closing this since it is covered by the great work done by @jahstreet, cf. #167, #249, #252 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In RSC context when the local hostname does not resolves to a loopback address, the canonical hostname is used and sent to other nodes.
This is a problem when running Livy on Kubernetes as another node won't be able to resolve the hostname. The proposed change is to return the IP address of the host when it's hostname resolves to an external IP.
Closes https://issues.apache.org/jira/browse/LIVY-560
Probably closes https://issues.apache.org/jira/browse/LIVY-372 too
How was this patch tested?
This was tested by successfully running Livy with Spark 2.4.0 on Kubernetes 1.13.2