Make TestRateLimiter locale-independent#469
Open
ppkarwasz wants to merge 1 commit into
Open
Conversation
The vendored Guava test formatted expected events with the default locale, so it failed on JVMs using a comma decimal separator. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored Guava
TestRateLimiterinflume-ng-coreformatted its expected events with the JVM default locale, so all 12 assertion-based tests failed on machines with a comma decimal separator (e.g.pl_PL), reportingR0,00instead ofR0.00.This passes
Locale.ROOTto the singleString.formatcall inFakeStopwatch.sleepMicros, matching the fix upstream Guava applied to the same test. Verified withmvn test -Dtest=TestRateLimiterunder bothpl_PL.UTF-8anden_US.UTF-8(23/23 pass in each).🤖 Generated with Claude Code