DependencyCollectionChecker: new session member#1899
Draft
cstamas wants to merge 4 commits into
Draft
Conversation
Introduce DependencyCollectionChecker, that is able to augment and re-collect the graph. By default, there is only NOOP implementation and this PR causes no change in Resolver behaviour, but this leaves ability to Resolver integrator to use this feature. Also, prepare OptionDependencySelector to be parameterized (by default is not) to be able to ignore or collect optional/excluded artifacts.
And it is resolver itself enforcing it, as a problematic checker may cause endless loops, so prevent it, but let escape hatch to set the maxRuns as config.
To be aligned with all other "optional" session stuff, once we will make the Optional<>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce DependencyCollectionChecker, that is able to augment and re-collect the graph. By default, there is only NOOP implementation and this PR causes no change in Resolver behaviour, but this leaves ability to Resolver integrator to use this feature.
Also, prepare OptionDependencySelector to be parameterized (by default is not) to be able to ignore or collect optional/excluded artifacts.
Note: DependencyCollectorDelegate may be best seen without whitespace, change is only about putting existing logic into loop w/ some cleanup.