Fix #11798: Preserve profile activation during consumer POM generation#12239
Open
gnodet wants to merge 1 commit into
Open
Fix #11798: Preserve profile activation during consumer POM generation#12239gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
…eration When readParentLocally() resolves a parent POM during BUILD_CONSUMER, it now uses CONSUMER_PARENT request type (which allows profile activation) instead of inheriting BUILD_CONSUMER (which suppresses it). This matches the behavior of resolveAndReadParentExternally() and ensures that properties defined inside profiles with property-based activation are correctly resolved for locally-resolved parent POMs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readParentLocally()resolves a parent POM duringBUILD_CONSUMER, it now usesCONSUMER_PARENTrequest type (which allows profile activation) instead of inheritingBUILD_CONSUMER(which suppresses it)resolveAndReadParentExternally()and ensures that properties defined inside profiles with property-based activation are correctly resolved for locally-resolved parent POMsTest plan
MavenITgh11798ConsumerPomProfileActivationTestpasses: parent POM definesdep.versionin a profile with property-based activation, child imports a BOM using${dep.version},installsucceedsFixes #11798
🤖 Generated with Claude Code