Skip to content

[ci][gh][workflow] explicit action hash and permissions #12581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmannibucau wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −4
Open

[ci][gh][workflow] explicit action hash and permissions #12581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/pr-automation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,15 @@ name: PR Automation
on:
pull_request_target:
types:
# zizmor: ignore[dangerous-triggers]
- closed

permissions: {}

jobs:
pr-automation:
name: PR Automation
uses: apache/maven-gh-actions-shared/.github/workflows/pr-automation.yml@v5
permissions:
issues: write
pull-requests: write
uses: apache/maven-gh-actions-shared/.github/workflows/pr-automation.yml@8599b638c78a2bec146a98d75d4c8b4e8458324f # v5

@slawekjaranowski slawekjaranowski Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intensionally here.

We assume our repo with shared actions is secure, we introduce every changes to it.

When we pin to hash we need update about 100+ our repos in every changes in shared actions.

We also manage permissions in shared action.
https://github.com/apache/maven-gh-actions-shared/blob/v5/.github/workflows/pr-automation.yml

@rmannibucau rmannibucau Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand but I dont think we should auto upgrade all repos like that, this is a good idea today which will likely blow up tomorrow so better to invest in automating it with a workflow in shared repo (on demand/manual) than relying on it by default IMHO

permissions being per workflow/job it is always better to explicit it in leaves than in parents IMHO, in particular when there it does have some serious impact on the run of the workflow (not having write perms will fail and you can wonder why - would be ok only if read only for PR IMHO)

@slawekjaranowski slawekjaranowski Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for permissions I'm ok,

but for hash version I afraid that will be more maintenance work for us - who will be take care about it?

@rmannibucau rmannibucau Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I had in mind was something like dependabot and we do approve after review as any "jar" dependency, wdyt?

9 changes: 7 additions & 2 deletions .github/workflows/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ on:
- master
workflow_dispatch:

permissions: {}

jobs:
update_release_draft:
uses: apache/maven-gh-actions-shared/.github/workflows/release-drafter.yml@v5
update_release_draft:
permissions:
contents: write
issues: write
uses: apache/maven-gh-actions-shared/.github/workflows/release-drafter.yml@8599b638c78a2bec146a98d75d4c8b4e8458324f # v5
7 changes: 6 additions & 1 deletion .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ on:
issue_comment:
types: [ 'created' ]

permissions: {}

jobs:
stale:
uses: 'apache/maven-gh-actions-shared/.github/workflows/stale.yml@v5'
permissions:
issues: write
pull-requests: write
uses: apache/maven-gh-actions-shared/.github/workflows/stale.yml@8599b638c78a2bec146a98d75d4c8b4e8458324f # v5
Loading