Conversation
The referenced page does not exist in the site documentation.
API docs, impl docs, compat docs, developer docs and Core ITs are not generated in this site build. Add comments explaining why they're commented.
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
The index.xml fix (removing the broken maven-configuration.html link) is correct — confirmed HTTP 404 on the live site.
However, the site.xml changes comment out 14 navigation links that all resolve successfully (HTTP 200) on the live Maven site (https://maven.apache.org/ref/4-LATEST/). These Reference links were deliberately fixed just weeks ago by a Maven PMC member (commit 60bc6e4). Commenting them out would degrade documentation navigation for users.
Verified issues:
- All 7 Descriptors Reference links work — POM, Settings, Toolchains, Core Extensions, Repository Metadata, Plugin Descriptor, Lifecycle Descriptor all return HTTP 200 under
api/. - All 5 Reference links work — Lifecycles, Plugin Bindings, Artifact Handlers, CLI options, Super POM all return HTTP 200 under
impl/andcompat/. - Both Development links work — Maven Developer Centre and Core ITs both return HTTP 200.
- The added comment "API documentation must be built separately with javadoc:javadoc" is inaccurate — these are Modello-generated descriptor pages (from
.mdomodel files), not Javadoc. - The PR body references "Fixes #1, #2, #3, #9" but those are unrelated, long-closed issues from 2013.
Suggestion: Keep the index.xml fix for the broken maven-configuration.html link, but drop all site.xml changes since the links work on the live site.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
The new commits did not address our previous feedback. The core issue remains:
14 valid navigation links are still being commented out in site.xml, but all return HTTP 200 on the live site:
- 7 Descriptors Reference links (POM, Settings, Toolchains, Core Extensions, Repository Metadata, Plugin Descriptor, Lifecycle Descriptor) — all verified HTTP 200 at
https://maven.apache.org/ref/4-LATEST/api/ - 5 Reference links (Lifecycles, Plugin Bindings, Artifact Handlers, CLI options, Super POM) — all verified HTTP 200; these paths were specifically corrected by commit 60bc6e4 (Hervé Boutemy, 2026-06-16) just 6 weeks ago
- 2 Development links (Maven Developer Centre, Maven Core ITs) — both verified HTTP 200
The only correct change is removing the broken maven-configuration.html link in index.xml (confirmed HTTP 404).
Recommendation: Keep the index.xml fix, revert all site.xml changes. The comment text "API documentation must be built separately with javadoc:javadoc" does not justify removing working navigation from the published site.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
| <item name="Repository Metadata" href="./api/maven-api-metadata/repository-metadata.html"/> | ||
| <item name="Plugin Descriptor" href="./api/maven-api-plugin/plugin.html"/> | ||
| <item name="Lifecycle Descriptor" href="./api/maven-api-plugin/lifecycle.html"/> | ||
| <!-- API documentation must be built separately with javadoc:javadoc --> |
There was a problem hiding this comment.
why removing these link?
they work https://maven.apache.org/ref/4.0.0-rc-6/
| <item name="Artifact Handlers" href="./impl/maven-core/artifact-handlers.html"/> | ||
| <item name="CLI options" href="./compat/maven-embedder/cli.html"/> | ||
| <item name="Super POM" href="./compat/maven-model-builder/super-pom.html"/> | ||
| <!-- Implementation modules documentation must be built separately --> |
| <item name="Maven Developer Centre" href="../../developers/index.html"/> | ||
| <item name="Maven Core ITs" href="../../core-its/index.html"/> | ||
| <!-- Developer documentation exists in separate repositories --> | ||
| <!--item name="Maven Developer Centre" href="../../developers/index.html"/--> |
There was a problem hiding this comment.
perhaps core-its require update, need to figure out
but developers link is useful (and yes, outside: that's intended)
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Lesson learned: Qwen 3 Coder Next is not as smart as DeepSeek v4 :-)
|
now that we focus on 1 change, it seems it is reverting #2201 and now I get that the page from rc4 = https://maven.apache.org/ref/4.0.0-rc-4/maven-configuration.html generated from https://github.com/apache/maven/blob/maven-4.0.0-rc-4/src/site/markdown/maven-configuration.md is now in a more complex generation step that is failing https://github.com/apache/maven/blob/maven-4.0.x/src/configuration-templates/maven-configuration.md.vm need to debug and fix #10961 |
elharo
changed the title
|
this PR should be dropped: instead of dropping link, fixing the generation is the right solution = started as #12657 as shown in previous analysis, the target doc is VERY valuable https://maven.apache.org/ref/4.0.0-rc-5/maven-configuration.html |
3 participants
Uh oh!
There was an error while loading. Please reload this page.