Skip to content

Resolve classified POM artifacts from the reactor [4.x] - #12658

Open
wilx wants to merge 2 commits into
apache:masterfrom
wilx:mdep-590-classified-pom-it
Open

Resolve classified POM artifacts from the reactor [4.x]#12658
wilx wants to merge 2 commits into
apache:masterfrom
wilx:mdep-590-classified-pom-it

Conversation

@wilx

@wilx wilx commented Aug 2, 2026

Copy link
Copy Markdown

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Description

ReactorReader currently returns the reactor project's build POM for every artifact whose extension is pom, without considering its classifier. Consequently, resolving an attached classified POM from the reactor returns pom.xml instead of the attached artifact.

This change limits the build-POM shortcut to unclassified POM requests. Classified POMs proceed through the existing artifact matching path, which selects the attached artifact by extension and classifier. Ordinary reactor POM and consumer-POM resolution remain unchanged.

Fixes apache/maven-dependency-plugin#1024

Tests

  • Full root mvn verify: all 38 modules passed with RAT enabled (2:01).
  • Complete unfiltered Core IT suite: 1,052 tests, 0 failures, 0 errors, 43 skipped (3:37).
  • Maven Core dependency reactor tests: 580 tests in maven-core, with no failures.
  • MavenITmdep0590ClassifiedPomArtifactFromReactorTest
  • MavenITmng8293BomImportFromReactor
  • MavenITgh11084ReactorReaderPreferConsumerPomTest

@wilx wilx changed the title Resolve classified POM artifacts from the reactor Resolve classified POM artifacts from the reactor [4.x] Aug 2, 2026
@wilx
wilx marked this pull request as ready for review August 2, 2026 16:26

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal fix that correctly limits the ReactorReader build-POM shortcut to unclassified POM requests. Classified POMs now correctly fall through to the attached-artifact matching path.

The fix is consistent with the existing classifier-aware logic already present in findInProjectLocalRepository (lines 336-337), which similarly restricts the consumer-POM lookup to unclassified POM requests.

The integration test adequately covers the regression scenario (producer attaches a classified POM, consumer resolves it from the reactor).

Minor observation: the test class name uses mdep0590 prefix (from the Maven Dependency Plugin JIRA tracker), while Maven core integration tests typically use mng or gh prefixes. Not a blocker.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of gnodet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MDEP-590] dependency:copy confused when asked to copy artifact with classifier and extension .POM

2 participants