https://issues.apache.org/jira/browse/MYFACES-4754: fix for mass upda…

api/src/client/package.json

@@ -13,36 +13,37 @@
   },
   "devDependencies": {
     "@istanbuljs/nyc-config-typescript": "^1.0.2",
-    "@microsoft/api-extractor": "^7.58.7",
-    "@types/chai": "^4.3.4",
-    "@types/fs-extra": "^11.0.1",
-    "@types/mocha": "^10.0.1",
-    "@types/node": "^18.15.12",
-    "@types/sinon": "^10.0.14",
+    "@microsoft/api-extractor": "^7.58.8",
+    "@types/chai": "^5.2.3",
+    "@types/fs-extra": "^11.0.4",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^25.9.3",
+    "@types/sinon": "^21.0.1",
     "babel-plugin-syntax-dynamic-import": "^6.18.0",
-    "chai": "^4.3.7",
-    "compression-webpack-plugin": "^10.0.0",
+    "chai": "^6.2.2",
+    "compression-webpack-plugin": "^12.0.0",
     "copy-webpack-plugin": "^14.0.0",
-    "cross-env": "^7.0.3",
-    "fs-extra": "^11.1.1",
+    "cross-env": "^10.1.0",
+    "fs-extra": "^11.3.5",
     "global-jsdom": "^29.0.0",
-    "html-webpack-plugin": "^5.5.1",
-    "jsdom": "^29.1.0",
-    "jsf.js_next_gen": "4.1.0-beta.17",
-    "mocha": "^11.7.5",
-    "npm-check-updates": "^22.0.1",
+    "html-webpack-plugin": "^5.6.7",
+    "jsdom": "^29.1.1",
+    "jsf.js_next_gen": "4.1.0-beta.19",
+    "mocha": "^11.7.6",
+    "nise": "^6.1.5",
+    "npm-check-updates": "^22.2.3",
     "nyc": "^18.0.0",
-    "replace-in-file": "^6.3.5",
-    "rxjs": "^7.8.0",
-    "sinon": "^15.0.3",
-    "terser-webpack-plugin": "^5.3.7",
-    "ts-loader": "^9.5.0",
-    "ts-node": "^10.9.1",
-    "tsx": "^4.0.0",
+    "replace-in-file": "^8.4.0",
+    "rxjs": "^7.8.2",
+    "sinon": "^22.0.0",
+    "terser-webpack-plugin": "^5.6.1",
+    "ts-loader": "^9.6.0",
+    "ts-node": "^10.9.2",
+    "tsx": "^4.22.4",
     "typedoc": "^0.28.19",
-    "typescript": "^6.0.0",
-    "webpack": "^5.105.0",
-    "webpack-cli": "^5.0.1",
+    "typescript": "^6.0.3",
+    "webpack": "^5.107.2",
+    "webpack-cli": "^7.0.3",
     "webpack-dev-server": "^5.2.4"
   },
   "ts-node": {

api/src/client/typescript/faces/api/_api_ae_stub.d.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 // Stub file consumed only by tsconfig.ae.json (api-extractor's compiler config).
 // api-extractor uses mainEntryPointFilePath (target/dts/_api.d.ts) as the real
 // entry — this file exists solely to satisfy TypeScript's "at least one input"

api/src/client/typescript/faces/impl/i18n/Messages.ts

@@ -47,7 +47,7 @@ export class Messages {
     /** @constant */
     ERR_TRANSPORT = "Transport type {0} does not exist";
     /** @constant */
-    ERR_EVT_PASS = "an event must be passed down (either a an event object null or undefined) ";
+    ERR_EVT_PASS = "an event must be passed down (either an event object null or undefined) ";
     /** @constant */
     ERR_CONSTRUCT = "Parts of the response couldn't be retrieved when constructing the event data= {0} ";
     /** @constant */

api/src/client/typescript/faces/impl/util/AsyncRunnable.ts

@@ -127,7 +127,7 @@ export abstract class AsyncRunnable<T> implements IAsyncRunnable<T>{
 
     /**
      * registers a finally functor
-     * @param func the functor for the finally handling chanin
+     * @param func the functor for the finally handling chain
      */
     finally(func: () => void): IAsyncRunnable<T> {
         // no ie11 support we probably are going to revert to shims for that one

api/src/client/typescript/faces/impl/util/FileUtils.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {Config, DomQuery, DQ, Es2019Array} from "mona-dish";
 import {ExtDomQuery} from "./ExtDomQuery";
 import {$faces, EMPTY_STR} from "../core/Const";

api/src/client/typescript/faces/impl/util/XhrQueueController.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {IAsyncRunnable} from "./AsyncRunnable";
 import {ExtLang} from "./Lang";
 const debounce = ExtLang.debounce;

api/src/client/typescript/faces/impl/xhrCore/XhrRequest.ts

@@ -445,7 +445,7 @@ export class XhrRequest extends AsyncRunnable<XMLHttpRequest> {
     private appendIssuingItem(formData: XhrFormData) {
         const issuingItemId = this.internalContext.getIf(CTX_PARAM_SRC_CTL_ID).value;
 
-        //to avoid sideffects with buttons we only can append the issuing item if no behavior event is set
+        //to avoid side effects with buttons we only can append the issuing item if no behavior event is set
         //MYFACES-4679!
         const eventType = formData.getIf($nsp(P_BEHAVIOR_EVENT)).value?.[0] ?? null;
         const isBehaviorEvent = !!eventType && eventType !== 'click';

api/src/client/typescript/faces/test/api/MyFacesABTest.spec.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {describe} from "mocha";
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
 const defaultMyFaces = StandardInits.defaultMyFaces;

api/src/client/typescript/faces/test/frameworkBase/LangTest.spec.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {expect} from 'chai';
 import {describe, it} from 'mocha';
 import {Lang} from "mona-dish";

api/src/client/typescript/faces/test/frameworkBase/_ext/monadish/XmlQueryTest.spec.ts

@@ -0,0 +1,16 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+

api/src/client/typescript/faces/test/frameworkBase/_ext/monadish/markups/tobago-with-header.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export const tobagoSheetWithHeader = `<tobago-sheet id="page:mainForm:s1" data-tobago-selection-mode="multi" data-tobago-first="0" rows="0" row-count="88" data-tobago-layout="{&quot;columns&quot;:[1.0]}">
                    <style nonce="" id="page:mainForm:s1:j_id_2n">#page\\:mainForm\\:s1{max-height:486px;}
                    </style>

api/src/client/typescript/faces/test/frameworkBase/_ext/monadish/markups/tobago-without-header.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export const tobagoSheetWithoutHeader = `<tobago-sheet id="page:mainForm:s1" data-tobago-selection-mode="multi" data-tobago-first="0" rows="0" row-count="88" data-tobago-layout="{&quot;columns&quot;:[1.0]}">
   <style nonce="" id="page:mainForm:s1:j_id_2n">#page\\:mainForm\\:s1{max-height:486px;}
   </style>

api/src/client/typescript/faces/test/frameworkBase/_ext/shared/XmlResponses.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export class XmlResponses {
 
     static EVAL_1 = `

api/src/client/typescript/faces/test/xhrCore/ClientWindow.spec.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {describe} from "mocha";
 import * as sinon from "sinon";
 import {Implementation} from "../../impl/AjaxImpl";

api/src/client/typescript/faces/test/xhrCore/XhrRequestProgress.spec.ts

@@ -1,3 +1,19 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
 import * as sinon from "sinon";
 import {Implementation} from "../../impl/AjaxImpl";

api/src/client/typescript/mona_dish/AssocArray.ts

@@ -21,7 +21,7 @@
  * The config system, this is similar!
  */
 import {IValueHolder} from "./Monad";
-import {Es2019Array} from "./Es2019Array";
+import {Es2019Array, pushChunked} from "./Es2019Array";
 
 /**
  * A nop as assign functionality (aka ignore assign)
@@ -76,7 +76,7 @@ export function append<T>(target: {[key: string]: any}, ...accessPath: string[])
                 if(!Array.isArray(lastPathItem.target[lastPathItem.key])) {
                     lastPathItem.target[lastPathItem.key] = [lastPathItem.target[lastPathItem.key]];
                 }
-                lastPathItem.target[lastPathItem.key].push(...value);
+                pushChunked(lastPathItem.target[lastPathItem.key], value);
             }
         }
     })();
@@ -159,7 +159,7 @@ function alloc(arr: Array<any>, length: number, defaultVal = {}) {
     let toAdd = [];
     toAdd.length = length;
     toAdd[length - 1] = defaultVal;
-    arr.push(...toAdd);
+    pushChunked(arr, toAdd);
 }
 
 
@@ -272,7 +272,7 @@ function _appendWithOverwrite(withAppend: boolean, target: { [p: string]: any },
             });
             target[key] = new Es2019Array(...[]);
             target[key].push(oldVal);
-            target[key].push(...newVals);
+            pushChunked(target[key], newVals);
         } else {
             let oldVal = target[key];
             let newVals: any[] = [];
@@ -283,7 +283,7 @@ function _appendWithOverwrite(withAppend: boolean, target: { [p: string]: any },
                 }
             });
 
-            target[key].push(...newVals);
+            pushChunked(target[key], newVals);
         }
     }
 }
@@ -300,9 +300,9 @@ function _appendWithoutOverwrite(withAppend: boolean, target: { [p: string]: any
             let oldVal = target[key];
             target[key] = new Es2019Array(...[]);
             target[key].push(oldVal);
-            target[key].push(...toAssign);
+            pushChunked(target[key], toAssign);
         } else {
-            target[key].push(...toAssign);
+            pushChunked(target[key], toAssign);
         }
     }
 }

api/src/client/typescript/mona_dish/Config.ts

@@ -1,4 +1,4 @@
-import {Es2019Array} from "./Es2019Array";
+import {Es2019ArrayFrom, pushChunked} from "./Es2019Array";
 import {IValueHolder, Optional, ValueEmbedder} from "./Monad";
 import {Lang} from "./Lang";
 const objAssign = Lang.objAssign;
@@ -101,7 +101,7 @@ export class Config extends Optional<any> {
         let newThis = shallowMerge(overwrite, withAppend, this.value, other.value);
         if (Array.isArray(this._value)) {
             this._value.length = 0;
-            this._value.push(...(newThis as any));
+            pushChunked(this._value as any, newThis as any);
         } else {
             Object.getOwnPropertyNames(this._value).forEach(key => delete this._value[key]);
             Object.getOwnPropertyNames(newThis).forEach(key => this._value[key] = newThis[key]);
@@ -224,7 +224,7 @@ export class Config extends Optional<any> {
             if (this.isArray(arrPos)) {
                 if (currKey != "") {
                     currAccessPos = Array.isArray(currAccessPos.value) ?
-                        Optional.fromNullable(new Es2019Array(...currAccessPos.value)
+                        Optional.fromNullable(Es2019ArrayFrom<any>(currAccessPos.value)
                             .find(item => {
                                 return !!(item?.[currKey] ?? false)
                             })?.[currKey]?.[arrPos]) :
@@ -237,7 +237,7 @@ export class Config extends Optional<any> {
                 //we noe store either the current array or the filtered look ahead to go further
             } else {
                 //we now have an array and go further with a singular key
-                currAccessPos = (Array.isArray(currAccessPos.value)) ? Optional.fromNullable(new Es2019Array(...currAccessPos.value)
+                currAccessPos = (Array.isArray(currAccessPos.value)) ? Optional.fromNullable(Es2019ArrayFrom<any>(currAccessPos.value)
                         .find(item => {
                             return !!(item?.[currKey] ?? false);
                         })?.[currKey]) :