Gradle "Go to source" on callstack entries in test results does not work#9459
Open
matthiasblaesing wants to merge 1 commit into
Open
Gradle "Go to source" on callstack entries in test results does not work#9459matthiasblaesing wants to merge 1 commit into
matthiasblaesing wants to merge 1 commit into
Conversation
The code always yielded the string representation of the current line as the string contenation is evaluated the the null check in the ternary expression is checked. That is never null and thus line is returned. What was meant here is that the first part of the string should be the "location" (classname) followed by a colon and either the line number or the method name. Add parantheses to fix this. Closes: apache#9454
matthiasblaesing
added
Gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code always yielded the string representation of the current line as the string contenation is evaluated the the null check in the ternary expression is checked. That is never null and thus line is returned.
What was meant here is that the first part of the string should be the "location" (classname) followed by a colon and either the line number or the method name.
Add parantheses to fix this.
Closes: #9454