audioutils: Add RTTTL parsing library#3477
Open
ghnotgood wants to merge 1 commit into
Open
Conversation
xiaoxiang781216
previously approved these changes
May 11, 2026
lupyuen
previously approved these changes
May 12, 2026
Member
|
@ghnotgood Please add "Signed-off-by" to your commit. Also add a simple message to the Commit Body, e.g. |
Contributor
Author
|
@lupyuen I am sorry, I forget again. Thank you. |
cederom
requested changes
May 12, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @ghnotgood :-)
- How this solution is differenf from nuttx-apps/examples/audio_rttl [1]? Why do you prefer this particular application?
- Did you test this solution on a real world hardware? Does it generate tones as intended? Can you please provide testing logs?
- The code is a tiny C and H file. There is no need to git clone it from external repo. Please add sources directly into the PR. When there is a new release of the upstream we will update it here too. NuttX aims to be self-contained and have least possible amount of external dependencies.
Add a simple library for parsing Ring Tone Text Transfer Language (RTTTL). Signed-off-by: Jiri Vlasak <jvlasak@elektroline.cz>
ghnotgood
dismissed stale reviews from xiaoxiang781216, linguini1, and lupyuen
via
84840fe
Contributor
Author
The example is an example. I am not sure how to use the example to play a sound I want in my application -- there is no API in header file. Moreover, it looks like The proposed library, on the other hand, lets a develop define how to make a sound, which may be generic NuttX audio driver or any hacked board-specific solution.
Yes, as stated in the Testing section of this PR. The build log is: Running the The
I did it, but now the check fails due to formatting issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
rtttl-c, a simple parsing library, to theaudioutilsdirectory.Impact
Developers may implement a procedure that makes sound
and then play a sound encoded in the RTTTL string (
"..."in the following)Testing
The testing code is
with the output of
When instead of
print_tone, there is aplay_toneprocedure with the board-specific code to make the sound, the Jingle Bells song is played.