apps/cmake: Make hello_rust_cargo buildable with cmake#3479
Conversation
* Resolve APPDIR. * Remove "debug" from RUST_PROFILE_FLAG. * Add JSON specification compatibility to RUST_PROFILE_FLAG. * Correct the directory structure for RUST_LIB_PATH. Signed-off-by: Shoji Tokunaga <toku@mac.com>
|
@no1wudi Could you help to review this PR? Thanks :-) |
|
@toku-mac The CI Check failed with this error: https://github.com/apache/nuttx-apps/actions/runs/25782691618/job/75736117186?pr=3479#step:4:84 Could you remove the Execute Permission from nuttx_add_rust.cmake? Thanks :-) |
|
Sorry, can you check commit 89b0558? |
* Correct the permissions of `nuttx_add_rust.cmake` to 644. Signed-off-by: Shoji Tokunaga <toku@mac.com>
|
@toku-mac Sorry there's a CMake formatting problem: https://github.com/apache/nuttx-apps/actions/runs/25786185066/job/75745216835?pr=3479#step:4:85 Could you run this then commit the the updated CMakefile, remember to add "Signed-off-by" to the commit: cd cmake
python3 -m venv .
source ./bin/activate
python3 -m pip install cmake-format
cmake-format nuttx_add_rust.cmake -o nuttx_add_rust.cmakeHere are the changes: |
* Apply cmake-format. Signed-off-by: Shoji Tokunaga <toku@mac.com>
|
Sorry to bother you again. |
|
Yep NuttX CI is happy now thanks :-) |
Summary
Impact
Testing
I confirm that changes are verified on local setup and works as intended:
Configuration:
Testing logs before change:
Testing logs after change:
PR verification Self-Check