Skip to content

HDDS-15313. Increase snapshot diff default thresholds. #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SaketaChalamchala wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

HDDS-15313. Increase snapshot diff default thresholds. #10385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hadoop-hdds/common/src/main/resources/ozone-default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4726,7 +4726,7 @@

<property>
<name>ozone.om.snapshot.diff.max.page.size</name>
<value>1000</value>
<value>5000</value>
<tag>OZONE, OM</tag>
<description>
Maximum number of entries to be returned in a single page of snap diff report.
Expand Down Expand Up @@ -4812,7 +4812,7 @@

<property>
<name>ozone.om.snapshot.diff.max.allowed.keys.changed.per.job</name>
<value>10000000</value>
<value>1000000000</value>
<tag>OZONE, OM</tag>
<description>
Max numbers of keys changed allowed for a snapshot diff job.
Expand Down
4 changes: 2 additions & 2 deletions hadoop-hdds/docs/content/feature/Snapshot-Configuration-Properties.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ These parameters, defined in `ozone-site.xml`, control how Ozone manages snapsho
* `ozone.om.snapshot.diff.db.dir`: Directory for SnapshotDiff job data. Defaults to OM metadata dir. Use a spacious location for large diffs.
* `ozone.om.snapshot.force.full.diff`: Force a full diff for all snapshot diff jobs (Default: false).
* `ozone.om.snapshot.diff.disable.native.libs`: Disable native libraries for snapshot diff (Default: false).
* `ozone.om.snapshot.diff.max.page.size`: Maximum page size for snapshot diff (Default: 1000).
* `ozone.om.snapshot.diff.max.page.size`: Maximum page size for snapshot diff (Default: 5000).
* `ozone.om.snapshot.diff.thread.pool.size`: Thread pool size for snapshot diff (Default: 10).
* `ozone.om.snapshot.diff.job.default.wait.time`: Default wait time for a snapshot diff job (Default: 1m).
* `ozone.om.snapshot.diff.max.allowed.keys.changed.per.job`: Maximum number of keys allowed to be changed per snapshot diff job (Default: 10000000).
* `ozone.om.snapshot.diff.max.allowed.keys.changed.per.job`: Maximum number of keys allowed to be changed per snapshot diff job (Default: 1000000000).

* **Snapshot Compaction and Cleanup**
* `ozone.snapshot.key.deleting.limit.per.task`: The maximum number of keys scanned by the snapshot deleting service in a single run (Default: 20000).
Expand Down
2 changes: 1 addition & 1 deletion ...e/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/snapshot/SnapshotDiffHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public class SnapshotDiffHandler extends Handler {
"Note the effective page size will also be bound by " +
"the server-side page size limit, see config:%n" +
" ozone.om.snapshot.diff.max.page.size",
defaultValue = "1000",
defaultValue = "5000",
showDefaultValue = CommandLine.Help.Visibility.ALWAYS
)
private int pageSize;
Expand Down
4 changes: 2 additions & 2 deletions hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ public final class OMConfigKeys {
public static final int OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES_DEFAULT
= 100;
public static final int OZONE_OM_SNAPSHOT_DIFF_REPORT_MAX_PAGE_SIZE_DEFAULT
= 1000;
= 5000;

public static final String OZONE_OM_SNAPSHOT_DIFF_THREAD_POOL_SIZE
= "ozone.om.snapshot.diff.thread.pool.size";
Expand Down Expand Up @@ -638,7 +638,7 @@ public final class OMConfigKeys {
= "ozone.om.snapshot.diff.max.allowed.keys.changed.per.job";
public static final long
OZONE_OM_SNAPSHOT_DIFF_MAX_ALLOWED_KEYS_CHANGED_PER_DIFF_JOB_DEFAULT
= 10_000_000;
= 1_000_000_000L;

public static final String OZONE_OM_UPGRADE_QUOTA_RECALCULATE_ENABLE
= "ozone.om.upgrade.quota.recalculate.enabled";
Expand Down