HDDS-15395. Grafana dashboard for container balancer#10398
Open
navinko wants to merge 1 commit into
Open
Conversation
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @navinko for working on this.
Comment on lines
+1062
to
+1063
| "datasource": { | ||
| "name": "dfm13nk97y9kwf" |
Contributor
There was a problem hiding this comment.
Don’t hardcode dfm13nk97y9kwf. Use ${datasource} like the other panels. Remove the hardcoded UID from the variable default too.
Comment on lines
+251
to
+253
| "expr": "sum(increase(container_balancer_metrics_data_size_moved_gb[$__range]))", | ||
| "legendFormat": "Moved Data Size (GB)", | ||
| "range": true |
Contributor
There was a problem hiding this comment.
should this be sum(container_balancer_metrics_data_size_moved_gb_in_latest_iteration) instead?
since the title of this panel shows 'Size Moved (Latest)'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Grafana dashboard for container balancer
Please describe your PR in detail:
Created a Grafana dashboard to display the metrics relevant to balancer operation.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15395
How was this patch tested?
Simulated unbalanced cluster -> Triggered balancer through CLI -> Captured dashboard screen shot and validated panel
Used same json "Ozone - Container Balancer Metrics.json" for current PR
Screen shots for references: