HDDS-14754. Add ZDU upgrade action to clean up leftover state - #10889
Open
errose28 wants to merge 2 commits into
Open
HDDS-14754. Add ZDU upgrade action to clean up leftover state#10889errose28 wants to merge 2 commits into
errose28 wants to merge 2 commits into
Conversation
errose28
added
the
zdu
errose28
marked this pull request as ready for review
July 29, 2026 00:43
dombizita
reviewed
Jul 30, 2026
Comment on lines
+51
to
+53
| if (!marker.delete()) { | ||
| throw new IOException("Failed to delete leftover OM prepare marker file " + marker); | ||
| } |
Contributor
There was a problem hiding this comment.
I believe this is really unlikely to happen, but this is different from SCM, to throw this exception. If this happens the marker file deletion won't happen until finalization called again? Will the finalization fail?
Contributor
Author
There was a problem hiding this comment.
Ideally OM and SCM should crash if there is an error during finalization. We can't have the ratis group in a mixed finalization state. The existing tests only check that an exception is propagated out of the version manager, but it looks like neither component will actually crash. I'll add this to the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OM Prepare for upgrade will be a no-op once ZDU is supported. There may be leftover state in the DB and VERSION file indicating that the OM was put in prepare mode in the prior version. We should remove this state in an upgrade action tied to OM version 100 (ZDU support) which will run when the OM is finalized. Similarly, SCM will no longer have a finalization-in-progress marker in its DB. This should be completely cleared out by the old version when SCM finishes finalizing, but we can also add an upgrade action to ensure it is removed.
What is the link to the Apache JIRA
HDDS-14754
How was this patch tested?
Unit tests for the upgrade actions were added, but they are difficult to test in a real cluster during the upgrade.
The existing mock upgrade actions for ZDU that were used in testing have been removed since we have concrete actions to test with now.